#16571: APNG (Animated PNG) for animations
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin von Gagern  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gagern/ticket/16571              |  f4a242733b301b813f316d8661485b77ad520ee7
   Dependencies:  #16570, #16645     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by niles):

 * cc: niles (added)


Comment:

 I'm slightly nervous about the long-term stability of the apng format, but
 given how easy it is to implement and how nice the results are, I suppose
 this is a reasonable addition.  Some questions/comments:

 * I would expect a method named `APngAssembler.frame` to return a frame.
 Would `add_frame` or `append_frame` or something similar be a better name
 for this?

 * Since the docstring of `APngAssembler.__init__` won't appear in the
 manual, it might be more useful to move that information to the class
 docstring.

 * most of the `APngAssembler` methods are missing doctests.

 * Not sure if it's part of this ticket, but I really think
 
[http://git.sagemath.org/sage.git/commit/?id=a60fe0b14aa4094c86c5efb387f9fd5a9706a218
 converting a generator to a list when rendering frames] is a bad idea.
 When there are lots of very large frames, this becomes becomes time and
 memory intensive.  What advantage do you see?

--
Ticket URL: <http://trac.sagemath.org/ticket/16571#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to