#16588: finite_state_machine.FSMState: New method fully_equal
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.3
Component: finite state | Resolution:
machines | Merged in:
Keywords: | Reviewers: Daniel Krenn
finite_state_machine | Work issues:
Authors: Clemens | Commit:
Heuberger, Daniel Krenn | 0f4cd95d215f9368d0ea9ecea8cf9fb87ee77449
Report Upstream: N/A | Stopgaps:
Branch: |
u/dkrenn/fsm/states_equality |
Dependencies: #16674 |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Clemens Heuberger, Daniel Krenn', 'oldvalue':
u'Clemens Heuberger'}):
* commit: f5b24c3d638ec739511a19c7c9b5513968e652bd =>
0f4cd95d215f9368d0ea9ecea8cf9fb87ee77449
* reviewer: => Daniel Krenn
* author: Clemens Heuberger => Clemens Heuberger, Daniel Krenn
Comment:
Code didn't check attribute color. This is now done. Needs cross-review.
Apart from the color-issue, the code looks fine, so a positive_review as
soon as the color-part is accepted.
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=cc772e4e80148e4327e4a4fb5aaa7d348f174181
cc772e4]||{{{added another doctest (check length of elements)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a12bf3c61eaf90c07b79333f0fce06ce6c15b359
a12bf3c]||{{{renamed check_equal to equal}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4e4801e53333adf53947085a209fa38f39b3241e
4e4801e]||{{{used equal in existing code (1 occurrence found, maybe there
are more)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=04579f393d5706a61fc96444525fc9827c6a55e0
04579f3]||{{{added is_monochromatic}}}||
||[http://git.sagemath.org/sage.git/commit/?id=afb1faf723bd88f0731ac61f23f11b2c45b4a457
afb1faf]||{{{Merge branch 'fsm/is_monochromatic' into
t/16588/fsm/states_equality}}}||
||[http://git.sagemath.org/sage.git/commit/?id=b8bee67c8f4a83f477d6133b62b2ea3f3942cf99
b8bee67]||{{{fully_equal has now a compare_color flag}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f595b2579eb7a717a8284bab87ef110558ec0470
f595b25]||{{{corrected handling of compare_color}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e537338801f246ef349f02e4635a55bebfb72cd3
e537338]||{{{== for finite state machines now handle comparing of colors
better (monochromatic finite state machines are considered equal)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4bd7fb065731edec660d3e38f86d8a9e6aa85902
4bd7fb0]||{{{documented ==-function for state colors (monochromatic)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0f4cd95d215f9368d0ea9ecea8cf9fb87ee77449
0f4cd95]||{{{added doctest to show behavior when states have colors}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16588#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
