#16696: correct a typo in doc of morphism.pyx
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: needs_work
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: minor | Merged in:
Component: | Reviewers: Peter Bruin
documentation | Work issues:
Keywords: | Commit:
Authors: | 3252cebcea12f857e79e01b410465fb48f411012
Frédéric Chapoton | Stopgaps:
Report Upstream: N/A |
Branch: |
u/chapoton/16696 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by pbruin):
* status: needs_review => needs_work
* reviewer: => Peter Bruin
Comment:
A few minor/trivial comments/questions:
- I don't think the change from `Sets` to `Monoids` in the doctest for
`SetMorphism.__init__()` is correct. The numerator function is neither a
morphism of additive monoids (`numerator(1/2) + numerator(2) !=
numerator(1/2 + 2)`) nor of multiplicative monoids (`numerator(1/2) *
numerator(2) != numerator(1/2 * 2)`).
- What is the reason for changing some docstrings to start with `r"""`
instead of `"""`? If I'm not mistaken, this is only needed if the string
contains backslashes. There don't seem to be any backslashes in the ones
where you added the `r`; on the other hand, the docstring of
`register_as_conversion()` does have one (so either it should start with
`r"""` or the backslash in `\ZZ` should be doubled).
- I am not a native English speaker, but I think "can not" should be
"cannot" in this context, and "should not it be" should be "shouldn't it
be" or "should it not be". Also, not using the shortened forms in these
cases sounds a bit artificial in my opinion. Anyway, this is really
starting to descend into trivialities...
--
Ticket URL: <http://trac.sagemath.org/ticket/16696#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
