#15803: Add a gcd algorithm for univariate polynomials over number fields using
pari
-------------------------------------+-------------------------------------
Reporter: lftabera | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: algebra | Resolution:
Keywords: gcd, number | Merged in:
field, univariate polynomial, | Reviewers: Peter Bruin
pari | Work issues:
Authors: Luis Felipe | Commit:
Tabera Alonso | 24cb800c6a09d87fe9eb1b1c86b2404602fa060b
Report Upstream: N/A | Stopgaps:
Branch: |
u/pbruin/15803-gcd_number_field_pari|
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* reviewer: => Peter Bruin
* branch: u/lftabera/gcd_number_field_pari =>
u/pbruin/15803-gcd_number_field_pari
* commit: 361310f76956a8a5553f3aa97274d8e276bb9c31 =>
24cb800c6a09d87fe9eb1b1c86b2404602fa060b
Comment:
Looks good to me and gives a measurable (though not dramatic) speedup in
the few unscientific tests that I've done.
The reviewer patch makes one simplification in the case where one of the
degrees is 0: if I'm not mistaken, we may assume that `self.parent() is
other.parent()` thanks to `@coerce_binop`. Other than that, just some
formatting fixes, typos etc. If you agree with my changes, it's a
positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/15803#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
