#16296: Speed improvements for categories with axioms
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: cython | Merged in:
performance categories | Reviewers: Travis Scrimshaw
Authors: Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5bad2ffde24824fc3aecd8110e459ba989bfe829
public/categories/speed_improvements_category_with_axiom-16296| Stopgaps:
Dependencies: #10963, #15801, |
#16309 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
* commit: 1e68e53b2ea1900cf043ea4545c3e51467721032 =>
5bad2ffde24824fc3aecd8110e459ba989bfe829
* branch: u/SimonKing/ticket/16296 =>
public/categories/speed_improvements_category_with_axiom-16296
* reviewer: => Travis Scrimshaw
Comment:
I've rebased it (it was trivial) and removed `get_all_axioms` since this
is still in python and we can access the module level attribute
`all_axioms` easily (before this was needed since [Simon] had made
`all_axioms` a cdef attribute). Since my change was removing an unused
method (except in testing), I'm going to set this to positive review since
the patch LGTM.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=743246397a74d4d22d70f4d702c8c2927e68609e
7432463]||{{{Merge branch 'u/SimonKing/ticket/16296' of
trac.sagemath.org:sage into
public/categories/speed_improvements_category_with_axiom-16296}}}||
||[http://git.sagemath.org/sage.git/commit/?id=72d1365ea7fc6b8846689f5f5b7db34150ee6119
72d1365]||{{{Very minor review changes.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=bc114381d5d72259084f28530c701fdc0087d4e1
bc11438]||{{{Removed get_all_axioms.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=5bad2ffde24824fc3aecd8110e459ba989bfe829
5bad2ff]||{{{Replaced get_all_axioms with all_axioms in doctests.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16296#comment:60>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
