#16718: Create a category for Cartesian products of groups
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  tscrim
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  group theory       |   Resolution:
       Keywords:  cartesian          |    Merged in:
  product, generators, categories    |    Reviewers:
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  f8539f428dfa3c770b35969c1a7668a89ddfe892
  public/groups/cartesian_product_category-16718|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Replying to [comment:7 ncohen]:
 > Could you add doctests for the infinite case ?

 Done.

 > Also, why `M.monoid_generators().cardinality() != float('inf')` instead
 of `M.monoid_generators().is_finite()` ?

 I've changed this to `in FiniteEnumeratedSets()` which is more
 restrictive, but it is safer. I've also added a second safety check in
 case `*_generators()` returns a tuple or a list (it shouldn't and maybe
 tuple/list should be considered as a objects in
 `FiniteEnumeratedSets()`?).

--
Ticket URL: <http://trac.sagemath.org/ticket/16718#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to