#12453: Refactor integer vectors using ClonableIntArray Cython data structure
-------------------------------------+-------------------------------------
Reporter: nborie | Owner: nborie
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorics | Resolution:
Keywords: Integer, vectors, | Merged in:
cython, clone, Cernay2012 | Reviewers:
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 822e1cb12097cf96039bb3251b782690fac1a42e
public/refactor_integer_vectors-12453| Stopgaps:
Dependencies: #10193 #14101 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
> I've implemented your algorithm and everything seems to work. Can you do
the rest of the review for this?
No, sorry. Your branch contains 14 commits, almost all of which are
entitled "Merge with develop". Besides, I see some code in your branch in
which you just change the indentation, and so it seems that I should not
re-review all that code, but given how your branch is made I have no way
to know what needs an actual review.
Besides, I can spend time on the review of any "local" thing (like this
enumeration algorithm) and I will do it gladly if you have anything
specific in mind, but I hate parents, elements and almost anything that is
immutable. I am the last person you want to review code like that.
I would start to make unpleasant reviews like: "It has been reported on
Sage-devel that having a cached function return a !UniqueRepresentation
object resulted in a memory leak. Clearly those integer vectors will be
used by cached function, so you are creating a new memory leak until this
finally gets fixed".
https://groups.google.com/d/topic/sage-devel/q5uy_lI11jg/discussion
So I'm sorry but you probably want somebody else to review this ticket.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/12453#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
