#16596: Add tests for the category of domains
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers: Julian Rueth
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/saraedum/ticket/16596 | 611f2ff2a9e195fa4b0a02a3beb0ca7f4120279b
Dependencies: #15191 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
* commit: 8436633ed36e9036e54339773b768c7a185b1f7f =>
611f2ff2a9e195fa4b0a02a3beb0ca7f4120279b
Comment:
Replying to [comment:3 saraedum]:
> I removed the `except AttributeError` on `is_exact()`, since all rings
in Sage implement `is_exact()`.
Since `Parent` implements `is_exact`, we're okay.
> You can change this to positive review if you are happy with my changes.
Done. Thanks for doing the review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=116bbfa272e4cd7437f9e4e4edfffc794d8e96de
116bbfa]||{{{Merge branch 'develop' into ticket/16596}}}||
||[http://git.sagemath.org/sage.git/commit/?id=611f2ff2a9e195fa4b0a02a3beb0ca7f4120279b
611f2ff]||{{{Added a note to _test_zero_divisors() for domains}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16596#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
