#16764: Add CM detection for elliptic curves over number fields
-------------------------------------+-------------------------------------
       Reporter:  cremona            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  elliptic curves    |   Resolution:
       Keywords:  complex            |    Merged in:
  multiplication                     |    Reviewers:
        Authors:  John Cremona       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  caf41e68e76a753268ce4f4dae36555f0003017b
  u/cremona/ticket/16764             |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by cremona):

 Replying to [comment:8 mstreng]:
 > While you're at it, could you change the wording in the first line of
 the documentation of has_cm for elliptic curves over the rationals to be
 less ambiguous?
 >
 > I've seen Complex Multiplication to mean over the base field and to mean
 over the algebraic closure, so "Returns True iff this elliptic curve has
 Complex Multiplication." is ambiguous. It could be "Returns True iff this
 elliptic curve has Complex Multiplication over the algebraic closure." or
 "Returns True iff this elliptic curve has a CM j-invariant." as in the
 number field case.

 Good point!  Thanks.  A suitable change for a reviewer's patch (as they
 used to be called)?

--
Ticket URL: <http://trac.sagemath.org/ticket/16764#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to