#16665: OA for n=408,600,792,856,1368,2328,...
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  afd77ce753321562f67eff40974650f9d283b48a
  u/vdelecroix/16665                 |     Stopgaps:
   Dependencies:  #16662             |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Replying to [comment:7 ncohen]:
 > Yo !
 >
 > > Few modifs at `u/vdelecroix/16665`
 >
 > Look good !
 >
 > > You prefer `K.primitive_element` instead of
 `K.multiplicative_generator`? I used to use the former... (not very
 important)
 >
 > I prefer the second, because it is clearer for me. But it's not my
 field, if I may sa

 Sorry: I prefer `multiplicative_generator` and you did use
 `primitive_element` (in `orthogonal_arrays.py` at line 1359 and
 `orthogonal_arrays_recursive.py` at line 1175). We seem to agree on using
 `multiplicative_generator`.

 > > Don't you prefer `raise AssertionError(msg)` instead of `assert
 False,msg`?
 >
 > I do.

 But you wrote `assert False,msg` at line 1177 in
 `orthogonal_arrays_recursive.py`

 > > How do you know that the following is satisfied
 > > {{{
 > >     # All blocks of PG should intersect 'AG_2_3' on !=2 AG_2_3.
 > >     assert all(len(AG_2_3.intersection(B)) != 2 for B in PG)
 > > }}}
 >
 > That's what the paper claims, and the reason why 'points' is defined as
 it is.

 I see.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16665#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to