#16662: OA for n=1046,1059,2164,3992,3994
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/ncohen/16662     |  2f936c57507cbd475f860a76b94ed44882d7de7b
   Dependencies:  #16604             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Yooooooo !

 > And:
 >  - what is the next value (like next_prime)

 That's easy to do. It would be the result of
 all_n(min=current_value,max=None).next()

 >  - what is the previous value (like previous_prime)

 This would be harder, but I'm not sure it is needed either `O_o`

 > The problem with your approach is that you store a lot of data. It is
 perhaps not as bad as what I imagine.

 it bothered me at first but we are thinking of k lists (and k<50 usually)
 or size around 2000 at most. How bad can that be ? If it were stored in C
 it would represent 500ko `:-P`

 > 1) why do you stop `n` at `N-3` in the first loop? I think that `n=N-1,
 m=1, a=1, b=0, c=0` is a valid input:

 Argg... Because I thought we could assume `a,c,b>0`, I did some changes
 then removed them, but I forgot one. If d=0 and c=0 I think that what the
 code does is roughly equivalent to Wilson's construction wth 2 truncated
 columns. But well, you are right, I will undo that !

 > 2) the check `d <= n` is not necessary because of the lower bound on
 `c`.
 >
 > I edit my commit at `u/vdelecroix/16662` to simplify the code with
 respect to 2). As soon as 1) is solve, I would be happy to set this to
 positive review.

 I just downloaded your branch but did not see anything new. I just merged
 it with the beta0 but I will add a commit in a second !

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/16662#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to