#16239: ZZ in the wrong category
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: categories | Resolution:
Keywords: integer ring, | Merged in:
category | Reviewers: Nicolas M. Thiéry
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 2897dfef672a6051698ae9065a44c8bd76010e9d
public/categories/fix_ZZ-16239 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:25 tscrim]:
> Replying to [comment:24 vdelecroix]:
> > It looks ok for me if you modify the doctest explaining what happened.
For me it is a facade issue as a facade should be childless (i.e. there is
no point in testing whether an element has a parent a given facade).
>
> It's not checking that it is a child of a facade parent, but that the
facade parents `__call__` (and the `_element_constructor_`?) doesn't
change the element. I'm wondering if facade parents should work with the
coercion framework differently...
Whenever possible, facade parents should indeed make sure that
F(F.an_element()) == F.an_element(), and bark on
F(something_outside). Now there are many occasions, like here
probably, where it might be hard, or costly, or just impossible to
achieve.
> Well, for now I will just add the warning to the doctest unless anyone
objects.
Yeah, that's life. I am ok with the change.
I ran all long tests, and with the little new commit, all tests pass. Back
to positive review!
Thanks!
Nicolas
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=2897dfef672a6051698ae9065a44c8bd76010e9d
2897dfe]||{{{#16239: finalized merge by updating a trivially failing
doctest}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16239#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
