#16655: Resolvable TD/OA and IncidenceStructure.relabel()
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5245ef6b93e10c1971257007d5e9d7b4839ecef6
u/vdelecroix/16655 | Stopgaps:
Dependencies: #16598 |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_info => positive_review
* reviewer: => Vincent Delecroix
* branch: u/ncohen/16655 => u/vdelecroix/16655
* commit: cffb31d23d074009d799af9d209a84e3b9bf8e54 =>
5245ef6b93e10c1971257007d5e9d7b4839ecef6
Comment:
Yooooooooooo !
> 1) There was a check that the sum of degrees is a multiple of the size
of the ground set... I changed it into a check that all degrees are the
same.
Yes of course `T_T`
> 2) The output was wrong (should be a pair if `certificate=True` and a
boolean if `certificate=False`).
Right right.
> 3) Now `self._classes` is a list of lists of blocks and not a list of
lists of indices
That's muuuuuuch better this way ! And my ugly sorting is not needed
anymore.
> 3) Some more documentation
>
> Tell me what you think.
Thank you for that ! Let's get this in !
Nathann
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=5245ef6b93e10c1971257007d5e9d7b4839ecef6
5245ef6]||{{{trac #16655: review}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16655#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
