#13982: rewrite sage.combinat.combinat.unordered_tuples using
itertools.combinations_with_replacement
-------------------------------------+-------------------------------------
       Reporter:  nbruin             |        Owner:  sage-combinat
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/rewrite_unordered_tuples-13982|  
373e5858694adf822102b2a1b9e40ce53cd776a6
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_work => needs_review


Comment:

 It's an unexpected format, in particular, the results aren't tuples. One
 can argue from the POV of ducktyping, it's okay, but I feel the
 inconsistency and the fact that it would fail a more explicit `isinstance`
 check the behavior should be standardized for all inputs. (Side note, I
 feel that should be a `needs_info`.)

--
Ticket URL: <http://trac.sagemath.org/ticket/13982#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to