#16806: Isogeny Bounds for Elliptic Curves over Number Fields
-------------------------------------+-------------------------------------
       Reporter:  elarson3           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-feature
      Component:  elliptic curves    |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Eric Larson        |    Reviewers:  John Cremona
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/cremona/ticket/16806             |  828ed6fee261a575c27e996d84c11c2bc7dabac0
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by cremona):

 * reviewer:   => John Cremona
 * branch:  u/elarson3/isogeny_bounds_for_elliptic_curves_over_number_fields
     => u/cremona/ticket/16806
 * commit:  87718324fe607636d420d0fa25874d7e1de67009 =>
     828ed6fee261a575c27e996d84c11c2bc7dabac0


Comment:

 I made some rather superficial changes to the new function and added a
 couple more examples.  The changes simlify the code while retaining
 exactly the same logic.   I had to rename the branch on trac (it is now
 u/cremona/ticket/16806) as that's the way it has to be (I cannot edit a
 u/elarson3 branch).

 My edits were superficial, otherwise I give the original new code a
 positive review.  That means that if you are happy with my additional
 changes we can jointly give it a positive review.  Before that I'll merge
 in the current develop branch and re-upload, but the changes I made should
 all be visible already in the commit 828ed6f.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=cadd58f3290e1c9e44b86d30195ce921c0f5db95
 cadd58f]||{{{Merge remote-tracking branch
 'trac/u/elarson3/isogeny_bounds_for_elliptic_curves_over_number_fields'
 into larson}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=828ed6fee261a575c27e996d84c11c2bc7dabac0
 828ed6f]||{{{#16806: reviewer's patch}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16806#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to