#16023: remove deprecated code in functions/ and symbolic/
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: task | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: symbolics | Resolution:
Keywords: deprecation | Merged in:
Authors: Ralf Stephan | Reviewers: Burcin Erocal, Karl-
Report Upstream: N/A | Dieter Crisman
Branch: | Work issues:
u/rws/ticket/16023 | Commit:
Dependencies: | 489c5a1d1e1a3e700f62062a94f8190a4ade296e
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by kcrisman):
* status: needs_review => needs_work
Comment:
> * make sure 13608 is still doctested
Yeah, although something similar is tested in symbolic/function.pyx this
is testing something very specific to exp, so that test should be kept,
probably just in the same place as the other example, or in some generic
tests place in the file.
> * check whether 2607, 6094, 10859 were doctested and remove those if
needed
The 2607 stuff actually just removes the deprecated ''method'' for local
max/min, but there is also the deprecated function it depended on which we
might as well remove at the same time, seems weird not to
{{{
numerical/optimize.py:233:find_maximum_on_interval =
deprecated_function_alias(2607, find_local_maximum)
numerical/optimize.py:234:find_minimum_on_interval =
deprecated_function_alias(2607, find_local_minimum)
}}}
These don't seem to have been tested, though, which is good for this
ticket. The stuff for 6094 I found is unrelated to this ticket and not
high priority, and 10859 was already all set.
> * see if just raising a slightly different error message in the number
field case will be enough
Here is current status if I just remove the call method entirely like you
did the others.
{{{
sage: gamma(i).n()
-0.154949828301811 - 0.498015668118356*I
sage: Q.<i> = NumberField(x^2+1)
sage: gamma(i)
---------------------------------------------------------------------------
TypeError: cannot coerce arguments: no canonical coercion from Number
Field in i with defining polynomial x^2 + 1 to Symbolic Ring
}}}
I guess we could keep the method and raise an error about embedding, or
keep this one. This is the only doctest failure in either directory, and
we would want to rescue the tests from that module.
----
What do you think? I hope it's okay with the multi back and forth on
this.
--
Ticket URL: <http://trac.sagemath.org/ticket/16023#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
