#16881: Rename number field __pari_* attributes to _pari_
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: number fields | Resolution:
Keywords: cache, | Merged in:
performance | Reviewers:
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | 3c62af7430a6724b07abb00dcf44b8fdc3abb16a
u/pbruin/16881-number_field_pari_attributes| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* status: needs_work => needs_review
* commit: 22f08ac36130ed6810608b47ae2527ad513f6d06 =>
3c62af7430a6724b07abb00dcf44b8fdc3abb16a
* branch: u/pbruin/16881-pari_bnf_caching =>
u/pbruin/16881-number_field_pari_attributes
Old description:
> The method `NumberField_generic.pari_bnf()` does not detect if the PARI
> `bnf` has already been certified and therefore always calls
> `bnfcertify()`. This is due to name-mangling of double-underscore
> attributes; more precisely,
> {{{
> getattr(self, "__pari_bnf_certified", False)
> }}}
> should be
> {{{
> getattr(self, "_NumberField_generic__pari_bnf_certified", False)
> }}}
New description:
The method `NumberField_generic.pari_bnf()` does not detect if the PARI
`bnf` has already been certified and therefore always calls
`bnfcertify()`. This is due to name-mangling of double-underscore
attributes; more precisely, in
{{{
getattr(self, "__pari_bnf_certified", False)
}}}
This can be solved by renaming all `__pari_*` attributes to `_pari_*` (`*`
= `bnf`, `bnf_certified`, `nf`, `polynomial`).
--
--
Ticket URL: <http://trac.sagemath.org/ticket/16881#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
