#16902: Advertise sig_check() better in the developers manual
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-6.4
Component: documentation | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/16902 | 313d884ab090c89dbaaa2a6958166d053e99627a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
Comment:
1) `sig_on/sig_off` is Sage specific or is it included within Cython? It
would be worth mentioning it. If it is Sage specific, why is that? and how
do people coding in Cython do? (seems to be `with nogil`). If it is
shipped with Cython, there should a pointer toward its documentation.
2) I am not sure that the following example is relevant.
{{{
def stack_sig_on():
sig_on()
sig_on()
sig_on()
# (some code)
sig_off()
sig_off()
sig_off()
}}}
I mean, what would be the purpose of such code? If it is none, it is still
interesting to mention it within a stack of calls like
{{{
def f1():
sig_on()
x = f2()
sig_off()
# ...
def f2():
sig_on()
# ...
sig_off()
return ans
}}}
3) The section `Releasing the Global Interpreter Lock (GIL)` was a bit
obscure to me. It would be nice to have one sentence to say what it is. I
guess it is related to my remark 1.
4) After reading the implementation of `alarm` I wonder why using `alarm`
in doctests rather than directly the `setitimer` from the `signal`
library? It is basically in `TESTS` blocks that such test
would appear, and involving there the `signal` library is not ugly (and
people reading it will learn about it instead of learning Sage wrapper!)
I learned many things reading it!
Thanks!
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16902#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
