#6309: [with patch, needs work] miscellaneous additions to simplicial complex
class; clique complex method for graphs
--------------------------------+-------------------------------------------
Reporter: bantieau | Owner: bantieau
Type: enhancement | Status: new
Priority: minor | Milestone: sage-4.0.3
Component: algebraic topology | Keywords:
Reviewer: | Author:
Merged: |
--------------------------------+-------------------------------------------
Comment(by jhpalmieri):
The patch doesn't apply cleanly; does this depend on #6099?
The {{{remove_facet}}} method needs some doctests. It also seems to have
a line using self.facets, not self.facets(). Would it in fact make sense
to just combine this with {{{remove_face}}}? That is, rewrite
{{{remove_face}}}: first check if the face being removed is a facet, in
which case use your code. Otherwise, use the old, presumably slower,
code. I don't think we need two separate methods. And before removing it,
you should probably check that it's actually a facet: make sure it's not a
face of any other facet.
Similarly, the {{{is_connected}}} method might fail if the complex was
constructed with {{{maximality_check}}} False.
You might check your {{{is_connected}}} method for speed -- compare to
this:
{{{
return self.graph().is_connected()
}}}
I expect that yours will be faster, even after the maximality check. If
you keep your code, you could put in a doctest like
{{{
sage: K = simplicial_complexes.RandomComplex(8,1) [or some other
simplicial complex]
sage: K.is_connected() == K.graph().is_connected()
True
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6309#comment:2>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
