#6164: [with patch, needs review] Phan's Mini-AES for educational purposes
--------------------------+-------------------------------------------------
Reporter: mvngu | Owner: somebody
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.0.3
Component: cryptography | Keywords: Mini-AES, AES, cryptography
Reviewer: | Author: Minh Van Nguyen
Merged: |
--------------------------+-------------------------------------------------
Comment(by malb):
'''Review Report'''
* as mentioned earlier, the module is beautifully documented. This is
really nice!
* I am wondering whether it would be better to have a directory
{{{block_cipher}}} with a file {{{miniaes.py}}} inside instead of
{{{block_cipher.py}}}?
* I guess it would be nice to have a function {{{sbox}}} which returns the
encryption S-Box for further study?
* AFAIK, we agreed to not use {{{\leq}}} but {{{<=}}} instead, because our
users might not speak LaTeX
* same for {{{\times}}}
* why are you more strict wrt types in {{{__call__}}} than in
{{{encrypt}}}?
* {{{D = \sigma_{K_0} \circ \gamma^{-1} \circ \pi \circ \theta \circ
\sigma_{K_1} \circ \gamma^{-1} \circ \pi \circ \sigma_{K_2} }}} isn't
exactly easily readable, but I guess it looks nice in the reference
manual. Maybe there is some compromise though?
* Maybe http://sphinx.pocoo.org/markup/misc.html#dir-tabularcolumns is a
good alternative to LaTeX tabular for readability?
Note, that most of the above are recommendations, not requirements. This
ticket is much better documented than almost every other module in Sage!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6164#comment:7>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
