#16851: Implement direct sum and tensor products for chain complexes and Koszul
complexes
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  tscrim
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebraic          |   Resolution:
  topology                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  01158352cb6751e7286023c3031ad1120fa3cca1
  u/tscrim/koszul_complexes          |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jhpalmieri):

 Replying to [comment:4 tscrim]:
 > > I think you can delete the line `zero = R.zero()` in
 `cartesian_product`.
 >
 > No, it's used when constructing the differentials.

 Before it gets used, `zero` is redefined by `zero = matrix(R, [])`, isn't
 it?

 > > Something similar happens with `tensor`.
 >
 > This one I'm not entirely sure I can fix. Would you be okay with just a
 `TODO` comment in the doc about this if I can't fix it?

 Sure.

 > > In that file, people have different styles, but I prefer importing
 functions only when you need them, not at the top-level. Having them at
 the top-level could potentially slow down startup times, I think.
 >
 > Importing them at the top-level makes the call to the function faster

 Just for the first call, right?

 > However we can lazy import the `koszul_complex.py` module, which we
 should do since I feel that it's not likely too many people will use this.

 Sounds good.

--
Ticket URL: <http://trac.sagemath.org/ticket/16851#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to