#15946: Cython warnings about mpz_t ("... referenced before assignment")
-------------------------------------+-------------------------------------
Reporter: mmezzarobba | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: cython | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/15946 | d76f8e7be8ad8f8a1a95b96e9413567f4389067e
Dependencies: #16583, #16910 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* commit: => d76f8e7be8ad8f8a1a95b96e9413567f4389067e
Old description:
> Similar to #16583, we should fix the declarations for `mpz_t` (and
> related types). This also involves fixing various bad usages of `mpz_t`
> (it was `ctypedef`'ed as `void*`, meaning you could do with it what you
> wanted and Cython wouldn't complain) and changing many many functions to
> pass an `mpz_t` instead of an `mpz_t*` (in particular, NTL functions
> `mpz_to_ZZ` and `ZZ_to_mpz`).
>
> See also [https://groups.google.com/forum/#!msg/sage-
> devel/bs4lnNwbINs/B2iVgxK7pCYJ]
New description:
Similar to #16583, we should fix the declarations for `mpz_t` (and related
types). This also involves fixing:
* various bad usages of `mpz_t` (it was `ctypedef`'ed as `void*`, meaning
you could do with it what you wanted and Cython wouldn't complain)
* changing many functions to pass an `mpz_t` instead of an `mpz_t*`. For
example the NTL interface functions `mpz_to_ZZ` and `ZZ_to_mpz` and the
`pow_computer` functions from p-adics.
See also [https://groups.google.com/forum/#!msg/sage-
devel/bs4lnNwbINs/B2iVgxK7pCYJ]
--
Comment:
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=dfc8ce1e411eee34ce50f69f37fe37c73cbe1f79
dfc8ce1]||{{{silence Cython warning about complicated declaration}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8bb6b48617d5e8cdf2a8f50f269332d591dcd8a7
8bb6b48]||{{{merge}}}||
||[http://git.sagemath.org/sage.git/commit/?id=14e730e84c2df7b5ccbe4aca490ae8c78d9fa43d
14e730e]||{{{Merge with 6.4.beta1}}}||
||[http://git.sagemath.org/sage.git/commit/?id=18a48429757e11afd32818b8940114e83a511824
18a4842]||{{{trac #16583, oops, correcting wrong merge}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c416fee312ff1d8ab43b3a3c650f44688a17c7b9
c416fee]||{{{Remove stuff which is not needed}}}||
||[http://git.sagemath.org/sage.git/commit/?id=b3d6aa2c24defa7cd22675f5540659b07a25401c
b3d6aa2]||{{{Further cleanup}}}||
||[http://git.sagemath.org/sage.git/commit/?id=20c767c6a446b441b1551a03a10fb09e1e4bb711
20c767c]||{{{Fix include of fmpq_poly.pxi in Cython doctest}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6fc03e3ea73f1a472b37661ae9ba9a72b4579dcc
6fc03e3]||{{{Get rid of mpz_t_offset hacks}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4a5d820ab2f296b0de1718690b2b13af30b719cf
4a5d820]||{{{Merge branch 'ticket/16910' into HEAD}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d76f8e7be8ad8f8a1a95b96e9413567f4389067e
d76f8e7]||{{{Fix mpz_t, mpq_t, mpf_t declarations}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15946#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
