#15586: Update Valgrind to 3.9.0
-------------------------------------+-------------------------------------
Reporter: jpflori | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
optional | Merged in:
Keywords: spkg valgrind | Reviewers:
Authors: Jean-Pierre Flori | Work issues:
Report Upstream: N/A | Commit:
Branch: | 556c5f499eb9d56927fa4d577a69652dbd984fe9
u/jpflori/ticket/15586 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
I dislike
{{{
#!diff
+if [ "$UNAME" = "Linux" ]; then
+ echo "Good - Valgrind works on Linux"
+ if [ "`uname -p`" = "ia64" ]; then
+ echo >&2 "But it does not work on Itanium"
+ exit 1
+ fi
+else
+ if [ "$UNAME" = "Darwin" ] && [ -z "`uname -p | grep PPC`" ] && [ `uname
-r | grep -Eo '^[0-9]+'` -ge 9 ];
+ then
+ echo "Good - Valgrind works on x86 and AMD64 Darwin 9.x or 10.x"
+ else
+ echo >&2 "Sorry, Valgrind only works on x86,AMD64,PPC32,PPC64,ARM Linux"
+ echo >&2 "and x86,AMD64 on Darwin 9.x/10.x"\
+ "(Mac OS X 10.5.x or later)"
+ exit 1
+ fi
+fi
}}}
If it doesn't work, fine, just let the build fail (one would hope that
upstream gives a reasonable error message in this case). Too often, these
kind of prevent building on systems which are perfectly fine.
--
Ticket URL: <http://trac.sagemath.org/ticket/15586#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
