#12264: eisenstein series mod p -- speed regression due to "temporary
workaround"
-------------------------------+------------------------
Reporter: was | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-6.4
Component: performance | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------+------------------------
Description changed by jdemeyer:
Old description:
> Three years ago Alex Ghitza introduced a patch in #5102 (that wstein
> positively reviewed) that said:
> {{{
> # this is a temporary fix due to a change in the
> # polynomial constructor over finite fields; this
> # is a notable speed regression, to be fixed soon.
> return a0fac*R(eisenstein_series_poly(k, prec).list(), prec=prec,
> check=True)
> }}}
> in the file {{{modular/modform/eis_series.py}}}. At the time, no ticket
> was opened, and now it's over three years later and this has not "been
> fixed soon". It should be!
>
> I noticed this when working on the closely related #11375.
New description:
From {{{modular/modform/eis_series.py}}}:
{{{
# This used to work with check=False, but that can only be
regarded as
# an improbable lucky miracle. Enabling checking is a noticeable
speed
# regression; the morally right fix would be to expose FLINT's
# fmpz_poly_to_nmod_poly command (at least for word-sized N).
if a0fac is not None:
return a0fac*R(eisenstein_series_poly(k, prec).list(),
prec=prec, check=True)
else:
return R(eisenstein_series_poly(k, prec).list(), prec=prec,
check=True)
}}}
--
--
Ticket URL: <http://trac.sagemath.org/ticket/12264#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
