#16975: avoid SAGE_ROOT in module_list.py for discrete Gaussians
-------------------------------------+-------------------------------------
Reporter: malb | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: build | Resolution:
Keywords: | Merged in:
Authors: Martin Albrecht | Reviewers: François Bissey
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/malb/t16975_sage_root | 92b152ef4c943150f1d467fd9554728e7495d703
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Martin Albrecht', 'oldvalue': ''}):
* status: needs_review => positive_review
* reviewer: => François Bissey
* author: => Martin Albrecht
Old description:
> The discrete Gaussian module relies on {{{SAGE_ROOT}}} in
> {{{nodule_list,py}}} but it shouldn't. See comment in #16968.
New description:
The discrete Gaussian module relies on {{{SAGE_ROOT}}} in
{{{nodule_list.py}}} but it shouldn't. See comment in #16968.
In this case the use of SAGE_ROOT to add an include directory was masking
the fact that one header was forgotten in depend. While that trick work
with plain sage it fails straight away in sage-on-gentoo. If the author
had used SAGE_SRC instead the mistake could have gone undiscovered for a
while. The usage of both SAGE_ROOT and SAGE_SRC are discouraged in
module_list.py.
--
Comment:
Since you kindly pushed I'll plus it.
--
Ticket URL: <http://trac.sagemath.org/ticket/16975#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
