#16908: Upgrade Maxima to 5.34.1
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: task | Status: positive_review
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
standard | Merged in:
Keywords: maxima | Reviewers: Jeroen Demeyer
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | e216b6fd358015ff4d22a11e24ed75d491121245
u/pbruin/16908-maxima-5.34.1 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:34 zimmerma]:
> > I assume you are mostly referring to the changes made by #16858; this
ticket only removes one digit.
>
> I refer to changeset {{{e216b6f}}} in comment [comment:27].
The only change made by that changeset in the `french_book` directory is
{{{
#!diff
--- a/src/sage/tests/french_book/integration_doctest.py
+++ b/src/sage/tests/french_book/integration_doctest.py
@@ -180,7 +180,7 @@ Sage example in ./integration.tex, line 838::
sage: t, y = var('t, y')
sage: desolve_rk4(t*y*(2-y), y, ics=[0,1], end_points=[0, 1], step=0.5)
- [[0, 1], [0.5, 1.12419127424558], [1.0, 1.4615901622888245]]
+ [[0, 1], [0.5, 1.12419127424558], [1.0, 1.461590162288825]]
Sage example in ./integration.tex, line 861::
}}}
The (earlier) commit that added the extra digits was 7cb1dd50 in #16858.
> Yes it would be better to only keep the minimum number of digits output
by all versions of Sage (since the one we use in our book, i.e., 5.9).
>
> The intent of those doctests is to only to check the examples that were
**printed** in the book still work in versions of Sage after 5.9.
OK, but surely a doctest where the only change is an increased precision
should be classified as "still working"? In any case, a user who types
the doctest in a newer version of Sage will also see the extra digits.
> Thus it makes no sense to add more digits than those that were actually
printed on http://sagebook.gforge.inria.fr/. Any doctests with a different
intent should go elsewhere in my opinion.
I don't disagree, but given that the doctests need to be updated in any
case, I don't understand why adding the extra digits is bad and adding
`...` is better. Feel free to open a ticket for it, though!
--
Ticket URL: <http://trac.sagemath.org/ticket/16908#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
