#13568: Quaternion Orders over Number Fields
-------------------------------------+-------------------------------------
       Reporter:  aly.deines         |        Owner:  AlexGhitza
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:  quaternion, order  |    Merged in:
        Authors:  Aly Deines         |    Reviewers:  tornaria
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mmasdeu/13568-review             |  73909fda05d5fe4dc5c8d39c9cb4e334d7e0aa24
   Dependencies:  #13509 - Pari      |     Stopgaps:
  nfhnf                              |
-------------------------------------+-------------------------------------

Comment (by mmasdeu):

 I started reviewing it, and made some changes. Some are to make it more
 pythonic, some are for clarity.

 I've set it to needs_work because the patch fails when using quaternion
 algebras not defined over number fields:
 {{{
 sage: A.<i,j,k> = QuaternionAlgebra(ZZ['x'].fraction_field(),-1,-1)
 sage: A.quaternion_order([1,i,j,k])
 ---------------------------------------------------------------------------
 UnboundLocalError                         Traceback (most recent call
 last)
 ...
 UnboundLocalError: local variable 'M1' referenced before assignment
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/13568#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to