#16629: Improve sage-fix-pkg-checksums
-------------------------------------+-------------------------------------
Reporter: charpent | Owner:
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-6.4
Component: build | Resolution:
Keywords: | Merged in:
Authors: Emmanuel | Reviewers: Jeroen Demeyer
Charpentier, Volker Braun (with | Work issues:
input from J. H. Palmieri) | Commit:
Report Upstream: N/A | 7a2c9da063f353392d4b6629a1172b162de4c2f5
Branch: | Stopgaps:
u/charpent/sage_fix_pkg_checksums_munches_build_pkgs__packagename__checksums|
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
* reviewer: => Jeroen Demeyer
Old description:
> The current (as of sage-6.3.beta5) version of sage-fix-pkg-checksums
> replaces the package version in build/pkgs/<package-name>/package-
> version.txt and checksums.ini
>
> An example of the result can be found in comment 27 of
> [http://trac.sagemath.org/ticket/16611]. It is also germane to
> [http://trac.sagemath.org/ticket/16489].
New description:
--
Comment:
Authors: please describe what this patch is supposed to do, because the
previous description was wrong (`package-version.txt` isn't changed by
`sage-fix-pkg-checksums`) and confusing! It's easier to review when I
know what this patch is supposed to achieve.
And fix the indentation please: no TABS, use indents of 4 spaces
And I would like to add an additional change:
{{{
upstream_pkg_name=${tarball%-*}
}}}
should become
{{{
upstream_pkg_name=${tarball%%-*}
}}}
to allow upstream versions with dashes (package-abc-1 should have package
name "package" and version "abc-1").
--
Ticket URL: <http://trac.sagemath.org/ticket/16629#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
