#16570: Animate example looks broken
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin von Gagern  |    Reviewers:  Jakob Kroeker
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gagern/ticket/16570              |  a5e766dcccea56a5af130dc4f7cde649997dc646
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jakobkroeker):

 * status:  needs_review => needs_work


Comment:

 Except the {{{x^2}}} plot (line 417, ff) everything is ok now.
 For that example {{{ymax}}} changes during the animation for me.
 If that is not by intention, I would set  {{{ymax=4}}} or similar.

 > Overwriting ​the dir builtin within the tests causes no immediate harm.
 Only when users adapt these tests and therefore loose access to the
 builtin, then we'd have some impact.

 That is exactly why I issued the usage of {{{dir}}} !

 > Nevertheless, I'll change the name to td

 in general I find self-descriptive naming like {{{'tempDir'}}} better,
 but that is up to you if you want to keep 'td' or change it to something
 more descriptive.

--
Ticket URL: <http://trac.sagemath.org/ticket/16570#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to