#6071: [with patch, needs work] Weight 1 Eisenstein series
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.0.3
Component: modular forms | Keywords: eisenstein series
Reviewer: | Author:
Merged: |
---------------------------+------------------------------------------------
Comment(by was):
REFEREE REPORT:
There is not a single example in this patch of computing an Eisenstein
series of weight 1. Can you add some examples?
Also, this seems very very wrong to me:
{{{
361 try:
362 d = self.dimension()
363 except NotImplementedError:
364 d = self._dim_eisenstein()
365 self.__module =
free_module.VectorSpace(self.base_ring(), d)
}}}
You've changed the dimension for *ambient* modular forms spaces to return
the dimension of the Eisenstein subspace in case the dimension function
isn't implemented. What if I take a space with both a cuspidal and
eisenstein part -- it'll just say the dimension of the whole space is the
dimension of the eisenstein subspace. Somehow I have the feeling you made
this change to get things to work in a special case of interest to you,
not worrying that you might break other cases.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6071#comment:4>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
