#17042: Improvement to subsets_with_hereditary_property
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: positive_review
Type: | Milestone: sage-6.4
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Dima Pasechnik
combinatorics | Work issues:
Keywords: | Commit:
Authors: | b6c4211b1df9f99084eeab017de2cd34189a0dfd
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/17042 |
Dependencies: |
#16994 |
-------------------------+-------------------------------------------------
Changes (by tscrim):
* status: needs_work => positive_review
Comment:
Replying to [comment:27 ncohen]:
> > You shouldn't use `assert` to validate user input:
>
> Whyyyyyyyyyyyyyyyyyyyy had it been declared bad ?.... How can it hurt
anybody ?...
>
> We should have rules about rules.
Assert statements are to check statements within the code that are
(suppose to be) always true, and hence, should not depend on (the always
potentially bad) user input. Thus if an assertion error is raised, there's
a bug in the code. It's more of a general programming thing. (It was also
something Jeroen enforced when he was release manager; IDK if Volker
continues this.) Also they can be turned off (IDR offhand if it's at
compile or run time) to encourage programmers to use them (or leave them
in code) more.
--
Ticket URL: <http://trac.sagemath.org/ticket/17042#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
