#17053: Add function for disjoint union and ordinal sum of posets
-------------------------+-------------------------------------------------
Reporter: | Owner:
jmantysalo | Status: needs_review
Type: | Milestone: sage-wishlist
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 3ce3c89b99ffe05dbab370c853e1b926b2fed6f3
Report Upstream: N/A | Stopgaps:
Branch: |
public/17053 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* commit: 5c8cf87e90acdf4f956df024678c6d07203fe9b8 =>
3ce3c89b99ffe05dbab370c853e1b926b2fed6f3
* branch: u/jmantysalo/add_function_for_direct_sum_of_posets =>
public/17053
Comment:
Hellooooo !
Here is a commit on top of yours. Set the ticket to `positive_review` if
you agree with it:
1) some english (has->have) and some commas
2) Rewrote '0,v' as {{{``(0,v)``}}} so that it appears as code in the doc.
As you also wrote 'integers', it may have led to believe that '0,v' is a
string.
3) Changes like that
{{{
#!diff
- if isinstance(self, FiniteMeetSemilattice) and \
- isinstance(other, FiniteMeetSemilattice):
+ if (isinstance(self, FiniteMeetSemilattice) and
+ isinstance(other, FiniteMeetSemilattice)):
}}}
code is easier to read when everything is aligned vertically.
4) Entries in the INPUT section should appear in the same order as the
arguments that the function accepts. So I reversed the order of
`verbose_relabel` and `labels`.
5) The tests did not pass in the graph/ folder because of function `join`.
So I did to it what you had already done to `disjoint_union` and
deprecated the old flag.
Nathann
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3ce3c89b99ffe05dbab370c853e1b926b2fed6f3
3ce3c89]||{{{trac #17053: Review}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17053#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
