#17090: Reviewer patch for #16803
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.4
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Volker Braun, | Reviewers:
Jeroen Demeyer | Work issues:
Report Upstream: N/A | Commit:
Branch: | 342d1520fbdb36041b1dc7e5a65c62e91dfb1e85
u/jdemeyer/ticket/17090 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by was):
Replying to [comment:30 jdemeyer]:
> Replying to [comment:29 was]:
>
> > Why did you delete the following functions:
> > {{{
> > _multiply_linbox
> > _multiply_multi_modular
> > }}}
> >
> These were simply unused. If you think we should keep them "for
reference", there is always the git log.
I'm against removing them. Just because they aren't explicitly used
elsewhere in Sage, doesn't mean they aren't useful to have. For example,
- I used them in testing the original patch (having multiple ways of
computing products in order to compare) that this is following up on.
- At one time Linbox was the fastest for multiplying matrices (at least in
2007, when Clement Pernet was my postdoc at UW). Now it's terrible, at
least as it is built in Sage. Having the function _multiply_linbox makes
it easier to test the speed of linbox versus flint (or multimodular) at
any point. If you remove it, then suddenly this becomes more difficult.
It's entirely plausible that linbox could again become faster than FLINT,
and it would be more difficult to know without this function.
- I personally don't trust FLINT, and having an easy alternative to test
(or swap out for) matrix multiplication makes me happier. I remember
clearly times in the past when FLINT gave flat out wrong answers when
multiplying large polynomials (burried deep in some p-adic cohomology
calculations), and -- when tracking this down -- being able to instrument
things so we could easily run the whole big computation with either FLINT
or PARI was critical.
--
Ticket URL: <http://trac.sagemath.org/ticket/17090#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
