#17084: Cleanup of assert in root systems
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: misc | Resolution:
Keywords: assert | Merged in:
Authors: Travis Scrimshaw | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17084 | 8da962bd1aba5fa4d28a7570b0541e2c45658d7a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
I not in favor of changing the `i not in self.index_set()` to raise an
`IndexError` for two reasons:
1. This is user input into a function, not a key or an index of a
sequence.
2. In the crystals code, there are related methods which do the check `i
not in self.index_set()` which currently raise a `ValueError`. I think
overall we should be consistent. If you feel that it should be an
`IndexError`, we should change all of those as well.
I don't hold such a strong opinion on the first, but I'm more concerned
about the second. The other changes are okay with me.
--
Ticket URL: <http://trac.sagemath.org/ticket/17084#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
