#16585: improved PolynomialSequence
-------------------------------------+-------------------------------------
Reporter: malb | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: commutative | Resolution:
algebra | Merged in:
Keywords: sd59 | Reviewers: Jakob Kroeker
Authors: Martin Albrecht | Work issues:
Report Upstream: N/A | Commit:
Branch: | 6e9ef02bae16c9ec564b901d2a573bcb8f65ee6d
u/malb/t16585_mpolynomial_sequence | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by jakobkroeker):
* status: needs_review => needs_work
* reviewer: => Jakob Kroeker
Comment:
First remark:
in the commit 1b7927cb54bb2943ad2ae1a43c8e3befdf6703b6
in file src/sage/rings/polynomial/multi_polynomial_ideal.py
at line 4139 I think it should be
{{{if d >= 0}}} instead of {{{if d > 0}}}
Second remark:
in the commit fffdbe0c8f9a248b3436d9c846bcd7b04a036d88
you introduce option terms=True to choose maximum number of terms.
I don't like it, because the option is not self-descriptive,
but try to convince me.
Third remark:
in 81c951fa9d428816a44dd8855d5a00ec4c3cf2b3
you change the default option 'choose_degree=False'
Changing default options is dangerous since it may break
existing code. Please give reasons why this change is still ok
commits
3b6c11a13eb300f0a2bf6acb56d7b9001b03e1f8
c2a8506eed5d9db0106b38d1c643f503d19ab54a
37fb67cce683927cd248b518602e81a2e33ac134
looks ok for me
I will continue the review tomorrow evening.
Jakob
--
Ticket URL: <http://trac.sagemath.org/ticket/16585#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
