#15808: Remove genus2reduction
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Jeroen Demeyer     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  1068fef87401f820747d4f938a56d2429afbe4b0
  public/ticket/15808                |     Stopgaps:
   Dependencies:  #15767             |
-------------------------------------+-------------------------------------

Comment (by pbruin):

 We can also decide to give up trying to imitate the original program
 perfectly and allow the power of 2 to be different.  I am attaching a
 patch that does this.

 I also think you used an incorrect criterion to decide when the 2-part of
 the conductor was not computed.  For example, one of the current doctests
 has the line
 {{{
 Conductor (away from 2): 954
 }}}
 Note that the "away from 2" part should only be there if the returned
 conductor is odd.  According to the PARI documentation, we should check if
 2 appears to the power -1 in the factorisation (fake at 2 in this case) of
 the conductor.  This is fixed by the last part of the patch.

--
Ticket URL: <http://trac.sagemath.org/ticket/15808#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to