#17108: IncidenceStructure.degree(set={1,2,3})
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/ncohen/17108     |  c34fda620e898708392becbbf8994d9065e29371
   Dependencies:  #17104             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Yo !

 > Right now
 > {{{
 > - def degree(self, p=None):
 > + def degree(self, p=None, set=None, sets_of_size=None):
 > }}}
 > There is no `point`...

 Oh sorry. But `p=None,pts=None` or `p=None,points=None` is not more
 meaningful either.

 > So you agree that it is unreadable ;-)

 Yes. What's the point ?

 I just want the user interface to make sense. The meaning of `I.degree(p)`
 is clear, the meaning of `I.degree(set=[1,2,3])` is not optimal but
 contains as much information as I could put, and
 `I.degree(sets_of_size=3)` is as clear as possible too.

 I thought of `I.degree(subset=[1,2,3])` but did not like it much. I don't
 see what the 'sub' does there.

 So well. I am sorry if it overwrites a 'set' keyword in the function (and
 if, unluckily, we need it) but well... Why is that even a problem ? I
 rename is as early as possible to make the code clearer.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17108#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to