#17131: Improve accuracy of polytopes.regular_polygon()
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  geometry           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/17131            |  0001941d064c6f1b1c0be2aea078eae0fb232b21
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Description changed by jdemeyer:

Old description:

> The function `polytopes.regular_polygon()` uses a hard-coded
> approximation of `pi` (3.14159265359) which has an error of 466 ulp.
> Moreover, it uses Python `float`s instead of `RR`, which breaks a doctest
> in #17130.

New description:

 The function `polytopes.regular_polygon()` uses a hard-coded approximation
 of `pi` (3.14159265359) which has an error of 466 ulp. Moreover, it uses
 Python `float`s instead of `RR`.

 Note: there are actually a lot of these fishy approximations (like
 `QQ(1618033)/1000000` for the golden ratio). Since this ticket is intended
 to avoid a doctest failure in #17130, I only fixed `regular_polygon()`.

--

--
Ticket URL: <http://trac.sagemath.org/ticket/17131#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to