#16933: Remove deprecated code
-------------------------------------+-------------------------------------
Reporter: aapitzsch | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: misc | Resolution:
Keywords: deprecated | Merged in:
Authors: André Apitzsch | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/aapitzsch/ticket/16933 | ea330d3c88c9a64e504cfb63652856964f79b119
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:6 aapitzsch]:
> Replying to [comment:5 jdemeyer]:
> > And `RootSystem(['A',2]).weight_lattice().pi` isn't deprecated
either...
> According to the comment it somehow is deprecated. But I can revert this
change.
What I meant is that the deprecation warning is commented out in the code
for reasons which are not entirely clear to me. I think you should just
uncomment that deprecation warning (with ticket number #16933).
> Replying to [comment:4 jdemeyer]:
> > Explicitly calling `Partition._repr_(self, compact=False)` hasn't been
deprecated so I guess the argument cannot be removed, it should just be
totally ignored but not disallowed.
> >
> Do you want me to deprecate the argument?
Perhaps replace the argument with `def _repr(self, compact=None):` and
then you can do in the code
{{{
if compact is not None:
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/16933#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
