#17138: LatticePoset: complements() is broken
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__complements___is_broken|
30eb2c633a5ee5f47c49e74dfdf8f99cc075ca7c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yo !
> > - (Do as you like but) the "comps" loop could have been rewritten as -
-
>
> This says `AttributeError: 'list' object has no attribute 'iteritems'`.
`O_o`
`comps` seems to be a dictionary in your code, not a list `O_o`
> Running `meet()` or `join()` will check that element belongs to the
lattice, the only exception is empty lattice. (Well, partly because of
that the code is non-optimal. But at least it works.)
`O_o`
Well, it would still be clearer to check 'element in self' rather than the
cardinality `O_o`
> I don't know. Can function from `HasseDiagram` be directly deleted
without deprecating it first? For now I changed phrasing in the message.
We can keep it like that, it does not matter much. One year from now we
will remove it, no harm done I guess.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17138#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
