#6269: [with patch, needs discussion] Coloring odds and ends
----------------------------+-----------------------------------------------
Reporter: kcrisman | Owner: kcrisman
Type: enhancement | Status: assigned
Priority: minor | Milestone: sage-4.1
Component: graphics | Keywords:
Reviewer: Nick Alexander | Author: Karl-Dieter Crisman
Merged: |
----------------------------+-----------------------------------------------
Comment(by kcrisman):
Replying to [comment:13 mvngu]:
> After testing the library of Sage 4.1.alpha0, I received the following
test failures, as reported at this by [http://groups.google.com/group
/sage-devel/browse_thread/thread/c15b5f57e380cc19 sage-devel] thread by
Robert Miller.
> {{{
> The following tests failed:
>
> sage -t -long devel/sage-main/sage/databases/database.py # 20
doctests failed
> sage -t -long devel/sage-main/sage/geometry/polyhedra.py # 1
doctests failed
> sage -t -long devel/sage-main/sage/graphs/graph.py # 25 doctests
failed
> }}}
> So when rebasing the patch {{{trac_6269.patch}}}, I think the part that
touches {{{sage/graphs/graph.py}}} should be left out. As Robert Miller is
currently working on a Cython implementation of a graph theory backend,
called c_graph (see #6085), perhaps the graph theory modules should not be
touched by the rebase so as to prevent any further complication with
getting c_graph in.
But rlm says in the same thread, "These are all due to the removal of
graph_isom.pyx, and I will be...". So that should not be the problem. In
fact, I am not sure how one can NOT include graph stuff, because the graph
theory modules need some of the coloring stuff, e.g. in graph_colorings.py
and several other such files there is the line
{{{
from sage.plot.plot import rainbow
}}}
and that is no longer where rainbow lives. Now, it is true that rainbow
lives in the global namespace, so maybe those lines are all redundant, but
as it stands they might cause failure at startup because sage.plot.plot
doesn't have rainbow anymore.
Since sage.plot.plot does import rainbow, maybe that's enough for rainbow
to be re-imported into those files from there for now. I don't feel I
have enough of an understanding of Python imports to judge all that. But
at the very least the import statements should be correct or deleted; it
makes no sense to leave in imports of a non-existent function which cause
no problems (now that I fixed the Integer thing noted above).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6269#comment:16>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
