#17165: Refactor some generic finite field code
-------------------------------------+-------------------------------------
       Reporter:  jpflori            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  finite rings       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jean-Pierre Flori  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jpflori/ticket/17165             |  70df9241921adad3f7412dc4218e1772923be10e
   Dependencies:  #16428             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 Replying to [comment:6 jpflori]:
 > I don't really get your second request (without actually thinking), so
 please help me, you mean:
 > * the `FiniteField_prime_modn` both inherits from
 `IntegerModRing_generic` and the base class for FF elements?
 yes, there is
 {{{
 class FiniteField_prime_modn(FiniteField_generic,
 integer_mod_ring.IntegerModRing_generic):
 }}}

 > So should we completely trash out the moved rational reconstruction
 code?
 yes, remove the code and move the doctests to
 `src/sage/rings/finite_rings/integer_mod.pyx`

--
Ticket URL: <http://trac.sagemath.org/ticket/17165#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to