#17170: Sagenb graphics displayhook
-------------------------------------+-------------------------------------
       Reporter:  vbraun             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-6.4
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Volker Braun       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vbraun/sagenb_graphics_displayhook|  
76b191a978a580a2d78e2b4c1fa55854e7261319
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by kcrisman):

 Seems to work properly in command line and for 2d in the notebook.  It'll
 be a moment before I can try with 3d (at least jmol, didn't think about
 tachyon) with the union of this and the new jmol, though the "static"
 image turned up okay, so I guess this works that way too.

 Doesn't
 {{{
 if isinstance(obj, SageObject) and hasattr(obj, '_graphics_'):
 }}}
 cover both 2d and 3d graphics?

 Also, you probably should do at least a minimal doctest for
 `sagenb_embedding` and `save_as`.

 Finally, what with all the changes to display stuff I think that it would
 be well worth asking for a little extra testing of any rc for this series
 ''visually''.

--
Ticket URL: <http://trac.sagemath.org/ticket/17170#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to