#17193: Adding a hash function to weak and strong tableaux
-------------------------------------+-------------------------------------
       Reporter:  aschilling         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:  weak and strong    |    Merged in:
  tableaux, hash                     |    Reviewers:  Travis Scrimshaw
        Authors:  Anne Schilling     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/combinat    |  2ad0eafc00c36a83345daaedd1b28bf0da32477d
  /hash-weak-strong-tableau-17193    |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * reviewer:   => Travis Scrimshaw


Comment:

 Two things:

 1 - The output of the hash is different for 32 bit machines. IMO a better
 test is `hash(t) == hash(t)`. (Also has the benefit of not having to
 change doctests when stuff changes.)
 2 - If the representation is not core or bounded, I think its better to
 call `super(WeakTableau_abstract, self).__hash__(self)` to not duplicate
 code and to use the (faster) cython from `ClonableList`.

--
Ticket URL: <http://trac.sagemath.org/ticket/17193#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to