#15753: Add BasisExchangeMatroid.isomorphism()
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner:
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-6.4
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/ticket/15753 | d2088e2ecfd8115fa36ed16af684d1ebdc66fe8e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by Rudi):
Replying to [comment:12 jdemeyer]:
> Given that `BasisExchangeMatroid` and `BasisMatroid` both inherit from
`Matroid`, there is no point in adding `cpdef _isomorphism(self, other)`
in the `.pxd` files for those.
>
OK, I'll remove these then.
> Also, what's the advantage of making `isomorphism()` (without
underscore) a `cpdef` method as opposed to just `def`?
We did not really think about this. But is there a disadvantage? Cpdef
just allows cdef child classes to override the function. While I don't see
why anyone would want that, why make it impossible? These are slow, high-
level functions, so a little pointer testing at the start of the function
won't affect overall efficiency.
I wanted to upload a patch but today sage -b exits with:
"src/convert.c:1:0: error: unknown value '10.10' of -mmacosx-version-min
scons: * * * [src/convert.os] Error 1"
I guess my OSX version is too new.
So feel free to make these changes, or wait until I find another way to
test + upload a patch.
--
Ticket URL: <http://trac.sagemath.org/ticket/15753#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
