#16935: Faster palindromes function for the Words library
-------------------------------------+-------------------------------------
Reporter: nadialafreniere | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: words, finite | Merged in:
words, palindromes | Reviewers:
Authors: Nadia Lafrenière | Work issues:
Report Upstream: N/A | Commit:
Branch: | def64a1a59757069be2840256a41dbc5951d5e07
u/nadialafreniere/16935 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by slabbe):
15. In the code of the {{{palindromes}}} method, you compute two tables:
`LPS` and `LPC`. If I understand correctly, the computation of `LPS`
depends on the computation of `LPC` but not conversely. Therefore, why are
they computed in parallel?
I would rather suggest if it is possible to write a method that
computes and return just `LPC`. Then, another method that computes and
return just `LPS` if it is possible to compute it from `LPC`. And finally
the method `palindromes` that returns all of the factors from the `LPS`
method.
Also, the palindromes method should have a `algorithm` argument
allowing to choose between the old and new way of doing things. This
facilitates the comparison of efficiency. Otherwise, it is more difficult
to see how faster is your new algorithm.
--
Ticket URL: <http://trac.sagemath.org/ticket/16935#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
