#16922: find_brouwer_van_rees_with_one_truncated_column
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/16922       |  955b67f0cf7f5f0e584a8f7fb0d3520c675fc37e
   Dependencies:  #16920             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Replying to [comment:12 ncohen]:
 > What is the point of making it decrease toward zero ? `O_o`
 >
 > To have more meaningful comments like
 > {{{if (vv > 0 and   # The new integer i is too big}}} ?
 >
 > Honestly I do not care, this will be rewritten soon anyway. But why
 would you do something like that ?
 >
 > You even do `for j in range(k-1,-1,-1)` which is totally equivalent to
 `for j in range(k)` given that you do not use j. Only to make it more
 complicated ?...

 Hum. `j` '''is''' useful as it is the remaining number of steps and allow
 to cut branches when the maximum number of steps allowed (i.e. `k_max`) is
 relatively small.
 {{{
 + if (vv > 0 and            # The new integer i is too big
 +     vv <= j*max_value and # The new integer i is too small
 +     vv not in D and       # We had it in D already
 +     vv not in new_D):     # We had it in new_D already
 }}}

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16922#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to