#15887: Make GSL random distributions seed from Sage's random state
-------------------------------------+-------------------------------------
       Reporter:  jason              |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  misc               |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jason Grout        |    Reviewers:  Andrey Novoseltsev
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/novoselt/ticket/15887            |  9a7bc85f68d1ab0b291edddfadea888f6a536b99
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vbraun):

 I get now the following on our 32-bit machine. It is all just numerical
 noise, can you add suitable `# rel tol` statements?
 {{{
 sage -t --long src/sage/gsl/probability_distribution.pyx
 **********************************************************************
 File "src/sage/gsl/probability_distribution.pyx", line 188, in
 sage.gsl.probability_distribution.SphericalDistribution
 Failed example:
     T.get_random_element()
 Expected:
     (-0.2922296724828204, -0.9563459345927822, 0.0020668595602153475)
 Got:
     (-0.2922296724828204, -0.9563459345927822, 0.0020668595602153454)
 **********************************************************************
 File "src/sage/gsl/probability_distribution.pyx", line 191, in
 sage.gsl.probability_distribution.SphericalDistribution
 Failed example:
     T.get_random_element()
 Expected:
     (-0.03633004347616311, 0.6459885817544099, 0.24825817345598164,
 0.7209346430129753)
 Got:
     (-0.0363300434761631, 0.6459885817544098, 0.24825817345598158,
 0.7209346430129753)
 **********************************************************************
 File "src/sage/gsl/probability_distribution.pyx", line 215, in
 sage.gsl.probability_distribution.SphericalDistribution.__init__
 Failed example:
     T.get_random_element()
 Expected:
     (-0.2922296724828204, -0.9563459345927822, 0.0020668595602153475)
 Got:
     (-0.2922296724828204, -0.9563459345927822, 0.0020668595602153454)
 **********************************************************************
 File "src/sage/gsl/probability_distribution.pyx", line 408, in
 sage.gsl.probability_distribution.RealDistribution
 Failed example:
     T.get_random_element()
 Expected:
     -8.404911172800617
 Got:
     -8.404911172800615
 **********************************************************************
 File "src/sage/gsl/probability_distribution.pyx", line 421, in
 sage.gsl.probability_distribution.RealDistribution
 Failed example:
     F.get_random_element()
 Expected:
     1.2392337861152563
 Got:
     1.239233786115256
 **********************************************************************
 File "src/sage/gsl/probability_distribution.pyx", line 461, in
 sage.gsl.probability_distribution.RealDistribution
 Failed example:
     T.get_random_element()
 Expected:
     0.7110581877139807
 Got:
     0.7110581877139808
 **********************************************************************
 3 items had failures:
    3 of  75 in sage.gsl.probability_distribution.RealDistribution
    2 of   7 in sage.gsl.probability_distribution.SphericalDistribution
    1 of  11 in
 sage.gsl.probability_distribution.SphericalDistribution.__init__
     [207 tests, 6 failures, 2.03 s]
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/15887#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to