#17180: Move and fix rational reconstruction
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.4
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17180 | f9645edf887bb52bc984d2cb57b8921dc95f02cb
Dependencies: #16428 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
Comment:
Hello,
In `rational_reconstruction.pyx` why did you import `Integer` from
`sage.rings.integer`?
The following also looks like a type as there is neither `w1` nor `w2`
{{{
mpz_swap(u1, v1) # u1 = v1; v1 = w1
mpz_swap(u2, v2) # u2 = v2; v2 = w2
}}}
Beyond that, it looks nice.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/17180#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
