#17270: cleanup of several minor points in sage/combinat
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: positive_review
Type: | Milestone: sage-6.4
enhancement | Resolution:
Priority: minor | Merged in:
Component: | Reviewers: Nathann Cohen
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 048ba5b396c3d5d1a42e243e7a31081176e8e1af
Frédéric Chapoton | Stopgaps:
Report Upstream: N/A |
Branch: |
u/chapoton/17270 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Hello !
Well, you do not do much harm with your pep8 patches but honestly a large
part of it is just intolerance.. Like replacing `p[i-1]` with `p[i - 1]`
`:-P`
Also, I personally prefer
{{{
if <condition>:
return <thing>
else:
return <another thing>
}}}
to
{{{
if <condition>
return <thing>
return <another thing>
}}}
And it would be cool to respect other people's writing style sooo... Well,
write code however you like, but please don't change the code only because
it is not your style.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17270#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
